SEP-6 + SEP-31: clarify that before sending the payment, the sending party should make a GET request to retrieve the expected amount_in
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reach the `GET /transactions/:id` endpoint to get the payment information before sending the payment to the Receiving Anchor.
…GET /transaction?id={id}` endpoint to get the payment `amount_in` before making the payment.
JakeUrban
previously approved these changes
May 13, 2022
Co-authored-by: Jake Urban <[email protected]>
marcelosalloum
added a commit
to stellar/stellar-demo-wallet
that referenced
this pull request
May 17, 2022
…sending the stellar payment (#275) ### What Make sure we get the `amount_in` from `GET /transactions` before sending the stellar payment. ### Why To be consistent with stellar/stellar-protocol#1203.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clarify that before sending the payment, the sending party should make a GET request to retrieve the expected
amount_in.Also added a few polishes to the text.
Why
Some anchors could use additive fees in the transactions, which would make the amount proposed by the Wallet diverge from the one approved by the Anchor.