Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use updated datastore #282

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Sep 6, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .

What

Sync stellar-etl with the latest changes from stellar/go. Primarily using the generated XDR for protocol 22 and updated datastore

Why

In preparation for Protocol 22 changes

Known limitations

N/A

@chowbao chowbao requested a review from a team as a code owner September 6, 2024 18:48
Copy link

socket-security bot commented Sep 6, 2024

Copy link

socket-security bot commented Sep 6, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/auth/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/dataproc/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/recaptchaenterprise/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/vision/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/go/[email protected], golang/cloud.google.com/[email protected], golang/github.com/cncf/xds/[email protected], golang/github.com/containerd/[email protected], golang/github.com/distribution/[email protected], golang/github.com/docker/[email protected]+incompatible, golang/github.com/docker/[email protected], golang/github.com/docker/[email protected], golang/github.com/fsouza/[email protected], golang/github.com/go-logr/[email protected], golang/github.com/google/martian/[email protected], golang/github.com/google/renameio/[email protected], golang/github.com/googleapis/gax-go/[email protected], golang/github.com/gorilla/[email protected], golang/github.com/gorilla/[email protected], golang/github.com/klauspost/[email protected], golang/github.com/moby/[email protected], golang/github.com/moby/[email protected], golang/github.com/morikuni/[email protected], golang/github.com/opencontainers/[email protected], golang/github.com/opencontainers/[email protected], golang/github.com/pkg/[email protected], golang/github.com/stellar/[email protected], golang/github.com/xeipuuv/[email protected], golang/github.com/xeipuuv/[email protected], golang/github.com/xeipuuv/[email protected], golang/go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected], golang/go.opentelemetry.io/otel/[email protected], golang/go.opentelemetry.io/otel/[email protected], golang/go.opentelemetry.io/otel/[email protected], golang/go.opentelemetry.io/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/golang.org/x/[email protected], golang/google.golang.org/[email protected], golang/google.golang.org/genproto/googleapis/[email protected], golang/google.golang.org/genproto/googleapis/[email protected], golang/google.golang.org/genproto/googleapis/[email protected], golang/google.golang.org/[email protected], golang/google.golang.org/[email protected], golang/google.golang.org/[email protected], golang/gotest.tools/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@chowbao
Copy link
Contributor Author

chowbao commented Sep 6, 2024

@SocketSecurity ignore-all

Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -959,6 +959,27 @@ func LedgerEntryToLedgerKeyHash(ledgerEntry xdr.LedgerEntry) string {
return ledgerKeyHash
}

// CreateDatastore creates the datastore to interface with GCS
// TODO: this can be updated to use different cloud storage services in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like this

@chowbao chowbao merged commit e53586a into master Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants