Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bugs related to transaction fees #279

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Aug 28, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .

What

There were a couple bugs for transaction fees

  • Transaction fees were negative due to not using the correct feeAccount for fee bump transactions
  • The feeCharged amount was fixed in P21 so there needs to be logic handling the correct calculation of feeCharged for <P21 only

Note that for Fee bump transactions feeAccount can be the same as sourceAccount

Slack thread for more context

Why

To correctly report transaction fees

Known limitations

Will need to backfill history_transactions to get correct fees data

@chowbao chowbao merged commit e82c6e5 into master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants