Build docker image using github actions #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amishas157
force-pushed
the
docker-image-using-gh
branch
3 times, most recently
from
925622c to
acc7584
Compare
amishas157
force-pushed
the
docker-image-using-gh
branch
from
16d2505 to
37fa6a5
Compare
use the right sha?
amishas157
force-pushed
the
docker-image-using-gh
branch
from
9c27cda to
68fafd9
Compare
sydneynotthecity
approved these changes
Aug 20, 2024
Comment on lines
+7
to
+8
| DEFAULT_ETLHASH := stellar/stellar-etl:$(shell git rev-parse --short=9 HEAD) | ||
| ETLHASH ?= $(DEFAULT_ETLHASH) |
There was a problem hiding this comment.
curious: why this was split into two vars?
There was a problem hiding this comment.
To support both versions - local build and github action build. If we use make docker-build locally, it will use ETLHASH = DEFAULT_ETLHASH. Otherwise, for github action, ETLHASH is passed as override env variable from branch
stellar-etl/.github/workflows/build.yml
Line 28 in af9eaa8
There was a problem hiding this comment.
Ah, makes sense. Thanks 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
Thoroughness
Release planning
semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .
What
This PR adds a github workflow which can be triggered manually to build and push docker image from a branch. This workflow pushes image to stellar-etl-dev dockerhub repo.
Why
Currently developer executes
make-docker buildcommand locally to build docker image for testing and pushes to personal dockerhub accounts. The github action will help to keep consistency in dev experience. We can decide later if we would like to build image on certain commit message etcTested using airflow branch https://github.com/stellar/stellar-etl-airflow/pull/480/files
Known limitations
[TODO or N/A]