Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bucketlist size to history_ledgers #275

Merged
merged 34 commits into from
Aug 12, 2024
Merged

Add bucketlist size to history_ledgers #275

merged 34 commits into from
Aug 12, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Aug 9, 2024 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .

What

This PR adds export of TotalByteSizeOfBucketList in history_ledgers table.

Why

The field will be used to create an alert when the bucketsize surpassed a threshold.

Known limitations

None

Test

Added new ranges in integration test to verify the field is correctly exported (Since old range did not have this field)

amishas157 added 30 commits August 5, 2024 16:08
@amishas157
Boiler plate
c391e61
@amishas157
Make the tests run
687ff9d
@amishas157
Truncate output file/dir before the export
8ea6e38
@amishas157
Make export transactions test run
6b7921f
@amishas157
Update the golden files
2b55e5b
@amishas157
prettier
b7c36b3
@amishas157
omit long running tests
b38fae5
@amishas157
Make all the tests work
9600e7b
@amishas157
prettier
3e2df01
@amishas157
update
8a956c5
@amishas157
Make all the test run
4211b9e
@amishas157
Add workflow to run integration tests
9b95998
@amishas157
revert me
b2a3ae6
@amishas157
Fix docker compose in workflow
00056df
@amishas157
use secret
f08b276 
add secret as env variable in github workflow

remove env from docker compose
@amishas157
pass env directly in docker compose run
fcffd97 
mount file and pass env

remove extra env

temp

cat temp

empty

printf

rearrange

validate json

workaround

cleanup

verbose
@amishas157
Fail the test intentionally
1d39d47
@amishas157
Revert "Fail the test intentionally"
31fb156 
This reverts commit 1d39d47.
@amishas157
find test coverage
77c0027
@amishas157
test overrides
b797bdf
@amishas157
Revert "test overrides"
eb0bfad 
This reverts commit b797bdf.
@amishas157
add coverage report and readme
6b4d818 
Fix coverage report

coverage fix
@amishas157
lower our test coverage standard
9d1693c
@amishas157
Remove duplicate functions
dae96ac
@amishas157
Add make command for lint
dd3d1d4
@amishas157
Cancel the previous runs if new commit is pushed
d41df7a
@amishas157
rename the job
6aac320
@amishas157
Update cmd/export_ledger_entry_changes_test.go
406f4dc
@amishas157
Update cmd/export_ledgers_test.go
b7442e1
@amishas157
Rename contract event golden file
b33d0d5
@amishas157 amishas157 marked this pull request as ready for review August 9, 2024 20:19
@amishas157 amishas157 requested a review from a team as a code owner August 9, 2024 20:19
sydneynotthecity
sydneynotthecity reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON object created in the golden files looks off. Once that's address will approve

testdata/ledgers/large_range_ledgers.golden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the golden files the JSON object name is not getting converted correctly. Do you know what the name is TotalByteSizeOfBucketList instead of total_byte_size_of_bucket_list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think it was due to 4f6168f. Also integration test did not run in this PR(since it is not a merge to master yet)
Updated the golden files

@amishas157 amishas157 changed the base branch from integration-test to master August 9, 2024 20:29
sydneynotthecity
sydneynotthecity approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amishas157 amishas157 merged commit cb48295 into master Aug 12, 2024
8 checks passed
@amishas157 amishas157 mentioned this pull request Aug 12, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amishas157 @sydneynotthecity