Update to use BufferedStorageBackend to read txmeta files #242
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: golang/github.com/stellar/[email protected] |
There was a problem hiding this comment.
Nothing blocking the merge. Changes look good
Might be worthwhile for us to discuss the operator experience for stellar-etl since we're also discussing for Ledger Exporter. Having the flags called through multiple methods feels weird now that we're deleting our extract from genesis code. Specifically, it might be worthwhile for us to collapse MustCommonFlags and MustArchiveFlags
cmd/export_account_signers.go
Outdated
| env := utils.GetEnvironmentDetails(isTest, isFuture, datastoreUrl) | ||
| commonArgs := utils.MustCommonFlags(cmd.Flags(), cmdLogger) | ||
| cmdLogger.StrictExport = commonArgs.StrictExport | ||
| env := utils.GetEnvironmentDetails(commonArgs.IsTest, commonArgs.IsFuture, commonArgs.DatastorePath) |
There was a problem hiding this comment.
not blocking for this PR: wdty about passing an env arg instead of IsTest and IsFuture? I think we'd need to plan the breaking change with Goldsky, but might be a better UX
There was a problem hiding this comment.
Yeah that'd be good. We need to refactor a lot of the params TBH
Hubble-386 although it doesn't have a description lol
cmd/export_ledger_transaction.go
Outdated
There was a problem hiding this comment.
Todo: This export process may be less useful now that we save raw XDR to GCS
There was a problem hiding this comment.
Hmm that's true. Throwing it in the ticket lol
Hubble-386
| } | ||
|
|
||
| // TODO: In the future CompressionType should be removed as it won't be configurable | ||
| BSBackendConfig := ledgerbackend.BufferedStorageBackendConfig{ |
There was a problem hiding this comment.
lol, BSBackendConfig :eyeroll:
Replaces
GCSBackendwith the releasedBufferedStorageBackendledgerbackend reader in the go monorepoBufferedStorageBackenddatastore-urlis nowdatastore-pathas the backend only takes the pathNetworkadded to env vars