Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract code fees #241

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add contract code fees #241

merged 1 commit into from
Apr 30, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Apr 30, 2024

Contract code resource breakdown was added in CAP-0054. Pull in these new fields for contract code ledgers

@chowbao chowbao requested a review from a team as a code owner April 30, 2024 15:14
sydneynotthecity
sydneynotthecity reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the CAP, it also looks like there were fields added to the ConfigSettings ledger entry. Is that true? Do you think they're worth adding to config_settings?

@chowbao
Copy link
Contributor Author

chowbao commented Apr 30, 2024

From the CAP, it also looks like there were fields added to the ConfigSettings ledger entry. Is that true? Do you think they're worth adding to config_settings?

There were no config_setting changes. It was additional fields to ContractCostType which isn't used in config_settings

@sydneynotthecity
Copy link
Contributor

There were no config_setting changes. It was additional fields to ContractCostType which isn't used in config_settings

Ah, I saw Stellar-contract-config-setting.x and assumed it was saved on config_settings. I see this is just the enum

@chowbao chowbao merged commit 834b7bb into master Apr 30, 2024
4 checks passed
@sydneynotthecity sydneynotthecity deleted the add-contract-code-fee-structure branch July 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chowbao @sydneynotthecity