Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable diagnostic events #229

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Enable diagnostic events #229

merged 2 commits into from
Mar 6, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Mar 6, 2024

  • Enable diagnostic events in stellar core configs
  • Use GetDiagnosticEvents() which converts contract events to diagnostic events in the absence of diagnostic events

@chowbao chowbao requested a review from a team as a code owner March 6, 2024 16:05
sydneynotthecity
sydneynotthecity approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sydneynotthecity sydneynotthecity merged commit c100c9d into master Mar 6, 2024
4 checks passed
@sydneynotthecity sydneynotthecity deleted the fix-diagnostic-events branch March 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chowbao @sydneynotthecity