Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete id from hist_assets and change id to asset_id in claimable_balances and offer #224

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Delete id from hist_assets and change id to asset_id in claimable_balances and offer #224

merged 3 commits into from
Jun 27, 2024

Conversation

cayod
Copy link
Contributor

@cayod cayod commented Feb 16, 2024

To unify the ID fields within the history_assets table, this PR implements the following adjustments:

  • The id field has been removed from the history_assets table.

  • The fields asset_id in claimable_balance, as well as SellingAssetID and BuyingAssetID in offer, now utilize asset_id for identification purposes instead of id.

@cayod cayod requested a review from a team as a code owner February 16, 2024 16:27
sydneynotthecity
sydneynotthecity reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought farmhash produced negative ints, which means that the data type would need to remain uint64. Please confirm whether this is true--everything else looks good

cmd/export_assets.go Show resolved Hide resolved
sydneynotthecity
sydneynotthecity approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chowbao chowbao merged commit 341d8c6 into master Jun 27, 2024
7 checks passed
@sydneynotthecity sydneynotthecity deleted the delete-id-from-hist-asset branch July 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cayod @sydneynotthecity @chowbao