Add fee bump envelope to soroban operations #211
Conversation
| case xdr.EnvelopeTypeEnvelopeTypeTx: | ||
| return transactionEnvelope.MustV1() | ||
| case xdr.EnvelopeTypeEnvelopeTypeTxFeeBump: | ||
| return transactionEnvelope.MustFeeBump().Tx.InnerTx.MustV1() |
There was a problem hiding this comment.
Interesting that we have to switch this ourselves. I'm kinda surprised there isn't an function in the xdr already to do this.
TIL there are more EnvelopeTypes! Do you think we need to handle other envelope types like EnvelopeTypeEnvelopeTypeContractId or EnvelopeTypeEnvelopeTypePoolRevokeOpId ?
There was a problem hiding this comment.
Yeah I didn't see one. It might be because EnvelopeType is overloaded. Like depending on what struct it is used in only certain values are valid.
For example, EnvelopeTypeEnvelopeTypeOpId is used in HashIdPreimage but not in TransactionEnvelope. TransactionEnvelope only has TransactionV0Envelope, TransactionV1Envelope (which is actually named EnvelopeTypeEnvelopeTypeTx), and EnvelopeTypeEnvelopeTypeTxFeeBump
There is a missing TransactionEnvelope type that was added
EnvelopeTypeEnvelopeTypeTxFeeBumpAdded a function to decode the TransactionEnvelope correctly to return the
contract_idandcontract_code_hash