Add closed_at to ledger entry changes tables #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneynotthecity
approved these changes
Nov 2, 2023
| //if err != nil { | ||
| // logger.Fatal(fmt.Sprintf("unable to read close time for ledger %d: ", seq), err) | ||
| //} | ||
| header = changeReader.LedgerTransactionReader.GetHeader() |
There was a problem hiding this comment.
nice find :) was this method easy to find? Or would it be helpful to add to the ingest documentation for ease of use in the future?
There was a problem hiding this comment.
It wasn't necessarily obvious because of all the different reader nesting. But when you know it exists it is easy. Probably would be useful in the ingest documentation. It would be nice to get a reader/backend to xdr.* mapping like {Reader: [xdr.TxMeta, xdr.CloseMeta, xdr.LedgerHeader, etc...]} without having to look through the xdr
There was a problem hiding this comment.
That's a good idea. Let's discuss with the rest of platform whether it makes sense to change the backend xdr mapping to be clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
closed_attoexport_ledger_entry_changestables.The standalone "from genesis" export_* use an empty
closed_atbecause the export_* are unused and theCheckpointChangeReaderdoesn't offer an easy way to get the ledger_sequence or closeMeta