Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ledger ops limit #204

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove ledger ops limit #204

merged 1 commit into from
Oct 18, 2023

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Oct 18, 2023

MaxTxSetSize does not account for soroban operations. Instead of doing an explicit check for operation types vs MaxTxSetSize just remove the check from stellar-etl and add a data quality check downstream (also core should already be checking for this error)

@chowbao chowbao requested a review from a team as a code owner October 18, 2023 16:27
sydneynotthecity
sydneynotthecity approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing. In the future, some flavor of this data quality check might be useful in dbt but no action required today

@chowbao chowbao merged commit 8c73c6b into master Oct 18, 2023
2 checks passed
@sydneynotthecity sydneynotthecity deleted the remove_ledger_ops_limit branch December 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chowbao @sydneynotthecity