Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update dapp-frontend.mdx so it includes how to use the StellarWalletsKit to connect the wallets #913

Conversation

earrietadev
Copy link
Contributor

This change includes a quick guide of how to use the StellarWalletsKit when using Freighter to request the public key and signing a transaction in the dapp-frontend guide: https://developers.stellar.org/docs/build/apps/dapp-frontend

This PR comes to complete this task: #766

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this worked out @earrietadev!! I think it's a much-needed addition to the tutorial!

I left a couple minor grammar-ish stuff here-and-there, and also asked a stupid question about Astro lol. Thanks again!

docs/build/apps/dapp-frontend.mdx Outdated Show resolved Hide resolved
docs/build/apps/dapp-frontend.mdx Outdated Show resolved Hide resolved
docs/build/apps/dapp-frontend.mdx Outdated Show resolved Hide resolved
docs/build/apps/dapp-frontend.mdx Show resolved Hide resolved
docs/build/apps/dapp-frontend.mdx Outdated Show resolved Hide resolved
@ElliotFriend ElliotFriend linked an issue Aug 16, 2024 that may be closed by this pull request
@ElliotFriend ElliotFriend self-requested a review August 16, 2024 15:05
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @earrietadev!!

@ElliotFriend ElliotFriend merged commit e2a08cb into stellar:main Aug 16, 2024
1 check passed
@janewang
Copy link
Contributor

Thank you @earrietadev!

@tupui
Copy link
Contributor

tupui commented Aug 16, 2024

lol I was going through this section right now and was just about to create an issue and say there was some issues with the new version of Freighter and some calls 😅 Awesome I will move to your kit!

janewang pushed a commit that referenced this pull request Sep 12, 2024
…alletsKit to connect the wallets (#913)

* [DOC] Update dapp-frontend.mdx so it includes how to use the StellarWalletsKit to connect the wallets

* Update docs/build/apps/dapp-frontend.mdx

Co-authored-by: Elliot Voris <[email protected]>

* Apply suggestions from code review

Co-authored-by: Elliot Voris <[email protected]>

---------

Co-authored-by: Elliot Voris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Getting Started section to include Stellar Wallet Kit
4 participants