Add cross contract convention guide #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yippee! Thank you! We're a bit behind in reviews but I'll assign this one early next week. |
|
No worries, I rushed this to have it open before the deadline 😅 Next week I am back on Thursday. |
briwylde08
reviewed
Aug 5, 2024
|
|
||
| ## Public API | ||
|
|
||
| All public functions of a contract can be called. Here as well, using a network explorer can be helpful as some propose to see the Rust interphase of a contract. Bindings can also be generated using the CLI: |
There was a problem hiding this comment.
This is fantastic, as usual, @tupui! Thanks for the contribution! I left a couple small nitpicks here and there, but this is pretty close to ready as-is.
Thanks!!
Co-authored-by: Elliot Voris <[email protected]>
|
Thanks @ElliotFriend for the review 😃 I think this is ready then. |
ElliotFriend
approved these changes
Aug 12, 2024
|
Thanks for the work here @tupui! Let's take the award conversation back to the corresponding issue. |
|
Awesome 🤩 thanks! That must have been quite a review effort for you guys this program, kudos 👏 |
|
Agreed!!! @ElliotFriend, @Julian-dev28, @Shaptic are review heroes!! |
janewang
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Structure for cross contract convention guide * Deps section * Last words section * Add handling resp * Add cross contract call * Add public API section * editorial & formatting * Apply suggestions from code review Co-authored-by: Elliot Voris <[email protected]> * Convert other occurrences of Soroban smart contract --------- Co-authored-by: Bri <[email protected]> Co-authored-by: Elliot Voris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #413
This PR adds a convention guide to show how to make cross contract call. There is a bit of discussion around the topic as well.
At first I was thinking about showing how to call Soroban Domain (I did that for my project now), but I then thought this should stay neutral. So this uses the add function which we already have in the example (and the snippet from the original issue) so that the reader can then more easily look at a full example and play with it.
Let me know if I should add anything 😃
cc @briwylde08