-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work with ContractSpecs in Other Languages #768
Work with ContractSpecs in Other Languages #768
Conversation
Hey @Myestery! Can you comment on the corresponding issue? I can't assign this to you unless you comment on the issue it seems! |
Hello @briwylde08 I spent a lot of time on it so I could add examples in 3 different languages: Java, PHP and Python |
Thank you so much! I'll get this assigned next week. Our reviews are a little behind so I think you in advance for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there @Myestery! This is a very good submission! Thanks for the work you've put into it, and for presenting it in a way that makes sense, and walks the user through a lot of really well described, well selected examples.
I've left a couple notes throughout (most quite minor), and took the liberty of changing some link formatting and code indentation here and there.
This is really nice guide, and I think it'll be a really valuable addition to our docs! Thank you!!
Thanks @ElliotFriend for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again!!
Thanks @Myestery! I'll merge this one and let's take the award conversation back to the corresponding issue. Yay! |
* initial commit * setup layout * contract spec complex and simple examples * add examples for getting and parsing contract events * add explanation of a contract spec * format mdx * fix url paths * Editorial and formatting * add support for rust and PHP in code examples * fix code samples * fix merge conflicts * fix some markdown link syntax * add PHP language to code highlighting languages * fine-tune code examples a bit * resolve PR comments --------- Co-authored-by: Bri <[email protected]> Co-authored-by: Elliot Voris <[email protected]>
meant to fix #606