Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANCHOR-688: Update flow diagrams #691

Merged
merged 2 commits into from
Jun 18, 2024
Merged

ANCHOR-688: Update flow diagrams #691

merged 2 commits into from
Jun 18, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Jun 17, 2024

No description provided.

@Ifropc Ifropc marked this pull request as ready for review June 17, 2024 23:48
@stellar-jenkins
Copy link

@JakeUrban
Copy link
Contributor

A couple things:

  • the font sizing seems to be slightly off for some of the components, can we fix that?
  • do we want to add sections of the integration guide explaining the on-hold flow?
  • don't we want to add the same changes for SEP-6?

@Ifropc
Copy link
Contributor Author

Ifropc commented Jun 18, 2024

This task was only for SEP-24, I think we can update SEP-6 in a separate task, as I want to catch up with some things before I'm off
As for 2 other comments: done!

@stellar-jenkins
Copy link

@JakeUrban
Copy link
Contributor

The font sizing issue still appears to be there

@Ifropc
Copy link
Contributor Author

Ifropc commented Jun 18, 2024

Sorry Jake can you point it out which texts are differ? I can't see it...

@JakeUrban
Copy link
Contributor

Its pretty minor, if its not straightforward to fix I think its fine.

Screenshot 2024-06-18 at 12 16 15 PM
Screenshot 2024-06-18 at 12 16 02 PM
Screenshot 2024-06-18 at 12 15 58 PM

@Ifropc
Copy link
Contributor Author

Ifropc commented Jun 18, 2024

It actually says it uses the same style
image
image

@JakeUrban
Copy link
Contributor

Ok, lets move forward then, its not a big deal.

@Ifropc Ifropc merged commit 0081da0 into main Jun 18, 2024
2 checks passed
@Ifropc Ifropc deleted the ANCHOR-688-update-diagrams branch June 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants