Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Soroban to Stellar Fundamentals #269

Merged
merged 52 commits into from
Dec 22, 2023
Merged

Adding Soroban to Stellar Fundamentals #269

merged 52 commits into from
Dec 22, 2023

Conversation

briwylde08
Copy link
Contributor

No description provided.

@briwylde08 briwylde08 marked this pull request as draft November 13, 2023 19:22
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@briwylde08
edit to accounts page
83c7ae7 
I'm iffy on if this one makes sense. Is smart contract data even relevant to account subentries? Is it assumed that we're not talking about smart contract data? Is it confusing to call out? To be discussed.
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 requested a review from rice2000 December 21, 2023 15:42
rice2000
rice2000 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@rice2000 rice2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but once you address those, I think it's good to go. Great work!!!

docs/fundamentals-and-concepts/lumens.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/lumens.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/networks.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/networks.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/lumens.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/stellar-data-structures/assets.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/stellar-data-structures/contracts.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/stellar-data-structures/contracts.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/stellar-stack.mdx Outdated Show resolved Hide resolved
docs/fundamentals-and-concepts/stellar-stack.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

4 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr269.previews.kube001.services.stellar-ops.com

@briwylde08 briwylde08 merged commit 3ccd325 into main Dec 22, 2023
2 checks passed
@briwylde08 briwylde08 deleted the soroban-in-stellar-fundamentals branch December 22, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh left review comments

@ElliotFriend ElliotFriend ElliotFriend left review comments

@Shaptic Shaptic Shaptic left review comments

@rice2000 rice2000 rice2000 approved these changes

Assignees

@ElliotFriend ElliotFriend

@briwylde08 briwylde08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@briwylde08 @stellar-jenkins @Shaptic @ElliotFriend @rice2000 @dmkozh