Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partner Experience: revamp ingestion docs and guidelines #168

Merged
merged 27 commits into from
Jul 20, 2023
Merged

Partner Experience: revamp ingestion docs and guidelines #168

merged 27 commits into from
Jul 20, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jun 27, 2023 •
edited
Loading

Revamp the ingestion filtering doc to align with partner experience goal of presenting less doc/config and more opinionated single best practice. Focus on ingestion strategy, monitoring, filtering operation, rules config, Include example of Asset and Account filter rules and how outcomes affect data stored in history.

To review, these are the changed pages:
https://developers-pr168.previews.kube001.services.stellar-ops.com/docs/run-platform-server/ingestion
https://developers-pr168.previews.kube001.services.stellar-ops.com/docs/run-platform-server/ingestion-filtering
https://developers-pr168.previews.kube001.services.stellar-ops.com/docs/run-platform-server/monitoring

Closes #147

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@sreuland sreuland requested review from urvisavla and a team June 28, 2023 19:21
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

Shaptic
Shaptic reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick readability pass, need to finish the rest of the files then do another pass for the content itself, but want to give feedback early and quickly

docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

mollykarcher
mollykarcher reviewed Jun 29, 2023
View reviewed changes
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Show resolved Hide resolved
docs/run-platform-server/ingestion-filtering.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion.mdx Outdated Show resolved Hide resolved
docs/run-platform-server/ingestion.mdx Outdated Show resolved Hide resolved
@sreuland sreuland requested a review from aditya1702 June 29, 2023 16:08
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

2 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

urvisavla
urvisavla reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@urvisavla urvisavla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Just a few suggestions and some minor nits.

@sreuland sreuland merged commit 81ff8c6 into stellar:partner_experience Jul 20, 2023
@sreuland sreuland mentioned this pull request Jul 20, 2023
Closed
@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr168.previews.kube001.services.stellar-ops.com

urvisavla pushed a commit that referenced this pull request Aug 9, 2023
@sreuland @urvisavla
Partner Experience: revamp ingestion docs and guidelines (#168)
b6aa598
@sreuland sreuland mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urvisavla urvisavla urvisavla approved these changes

@Shaptic Shaptic Shaptic left review comments

@aditya1702 aditya1702 Awaiting requested review from aditya1702

@mollykarcher mollykarcher Awaiting requested review from mollykarcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sreuland @stellar-jenkins @Shaptic @mollykarcher @urvisavla @gre3n3yes34