Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLedgerEntries: Outline building and parsing all sorts of LedgerKeys #1060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 25, 2024

This is marked as "ready" to see the preview! Please don't review it fully yet.

This makes the following changes:

  1. Add a guide on building + parsing account and trustline entries
  2. Improve the guide on building + parsing contract data, instances, and WASMs

As part of (2) I tried to morph it to be in line with the way (1) is explained. Notice that I've removed all of the base64 cruft: this is intentional as these can quickly become out of date and the guide is structured to teach someone to fish rather than giving them a base64-encoded fish.

Things still left to do:

  • more references to the Lab and leveraging xdrFormat: "json"
  • references to the stellar-cli to encode/decode structures
  • curl-esque examples

Closes #469.

For Reviewers

I recommend viewing the entire Markdown file in this PR as-is and comparing it to the existing page rather than going line-by-line as the changes are significant and hard to parse out of a diff.

@Shaptic Shaptic added documentation Improvements or additions to documentation rpc-sdk-scrum labels Oct 25, 2024
@Shaptic Shaptic self-assigned this Oct 25, 2024
@Shaptic Shaptic marked this pull request as ready for review October 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rpc-sdk-scrum
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

getLedgerEntries: add meaningful coding examples
1 participant