Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDP-1155] decommission stellar-multitenant CLI #261

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

marwen-abid
Copy link
Collaborator

Note

Making these changes wasn't costly, so if anyone has a different opinion about how to organize code I can make that change.

What

Why

  • CLI is redundant, we already have the admin API for doing the same thing. If a CLI is needed, it can be built as a standalone wrapper around the API.

Checklist

PR Structure

  • This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR title and description are clear enough for anyone to review it.
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@marwen-abid marwen-abid requested a review from a team April 16, 2024 23:38
@marwen-abid marwen-abid self-assigned this Apr 16, 2024
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests April 16, 2024 23:38 — with GitHub Actions Inactive
@marwen-abid marwen-abid had a problem deploying to Receiver Registration - E2E Integration Tests April 16, 2024 23:38 — with GitHub Actions Failure
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests April 16, 2024 23:45 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests April 16, 2024 23:45 — with GitHub Actions Inactive
@marwen-abid marwen-abid force-pushed the chore/SDP-1155-decom-stellar-mtn-cli branch from fb76ac7 to a7cf0a5 Compare April 16, 2024 23:45
@marwen-abid marwen-abid temporarily deployed to Receiver Registration - E2E Integration Tests April 16, 2024 23:45 — with GitHub Actions Inactive
@marwen-abid marwen-abid temporarily deployed to Anchor Integration Tests April 16, 2024 23:45 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Copy link
Collaborator

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marwen-abid marwen-abid merged commit 28eb2e3 into develop Apr 17, 2024
9 of 10 checks passed
@marwen-abid marwen-abid deleted the chore/SDP-1155-decom-stellar-mtn-cli branch April 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants