Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo #255

Merged
merged 21 commits into from
Dec 16, 2021
Merged

Monorepo #255

merged 21 commits into from
Dec 16, 2021

Conversation

quietbits
Copy link
Contributor

@quietbits quietbits commented Nov 18, 2021

  • Added workspaces demo-wallet-client, demo-wallet-server, and demo-wallet-shared (in packages)
  • Moved constants, helpers, and methods to shared
  • Check root package.json for scripts to run for development and builds

Currently shared code can be imported as shown below. I'm not a huge fan of having to specify /build (we need to use transpiled JS code instead of TS), but it works for now. We can spend more time later to make this better.

import {...} from "demo-wallet-shared/build/...;
  1. demo-wallet-server will act as a backend server for sep-10 client attribution (transaction signing) and also serve a stellar.toml file.
  2. during the sep-10 flow, the wallet client will request a challenge from the anchor server, that challenge gets passed to the wallet server for signing (client attribution) and returned to the wallet client.
  3. the wallet client will then sign that challenge before sending the challenge transaction back to the anchor server for verification.

now seen in the sep-10 flow:
image

TODO: add diagram

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

* Set demo-wallet-client's node engine version to `>=14`, rather than 14
* Move Dockerfile to Dockerfile-client, switch image from Ubuntu to Node (since we're using that in other areas of SDF to improve reliability of builds
* Create Dockerfile-server, for the server half
* Edit Makefile to do docker-build-client & docker-build-server, docker-push-client & docker-push-server, instead of just one
* Move demo-wallet-client's `yarn start` to `yarn dev`, since `yarn start` should be a prod-ready command
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@tprobinson
Copy link
Contributor

PR previews will still be broken until I get Jenkins and Kube merged. In the meantime feedback welcome on anything I've changed.

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

1 similar comment
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Dockerfile-client Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@stellar-jenkins
Copy link

@stfung77 stfung77 merged commit 5207162 into master Dec 16, 2021
@stfung77 stfung77 deleted the il-monorepo branch December 16, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants