-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo #255
Monorepo #255
Conversation
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
* Set demo-wallet-client's node engine version to `>=14`, rather than 14 * Move Dockerfile to Dockerfile-client, switch image from Ubuntu to Node (since we're using that in other areas of SDF to improve reliability of builds * Create Dockerfile-server, for the server half * Edit Makefile to do docker-build-client & docker-build-server, docker-push-client & docker-push-server, instead of just one * Move demo-wallet-client's `yarn start` to `yarn dev`, since `yarn start` should be a prod-ready command
Something went wrong with PR preview build please check |
PR previews will still be broken until I get Jenkins and Kube merged. In the meantime feedback welcome on anything I've changed. |
Something went wrong with PR preview build please check |
Something went wrong with PR preview build please check |
1 similar comment
Something went wrong with PR preview build please check |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
Preview is available here: |
demo-wallet-client
,demo-wallet-server
, anddemo-wallet-shared
(inpackages
)constants
,helpers
, andmethods
to sharedpackage.json
for scripts to run for development and buildsCurrently shared code can be imported as shown below. I'm not a huge fan of having to specify
/build
(we need to use transpiled JS code instead of TS), but it works for now. We can spend more time later to make this better.now seen in the sep-10 flow:
TODO: add diagram