Build system changes for v22.0.0 #4522
Merged
+118
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsdf
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sequence of cherry picks of (mostly) miscellaneous build-system infrastructure that I've recently landed on master transplanted onto the v22.0.0 branch.
Each somewhat improves the build situation (eg. enabling tracy, disabling memory tracking, fixing asan, cleaning more thoroughly, forcing rust toolchain version identity) but none of them are essential for making the v22.0.0 release. You could take any or none of them, it'll be ok either way.
There is also 72c5f9d which removes some stale cost-type adjustments in BUILD_TESTS-only code that's only active if you do multi-protocol replay -- the thing where we can run one tx twice, once on p21 and once on p22 -- and it might be nice to have that fixed so that we can do some more-confidence-inspiring side-by-side testing of p21 txs on the p22 codebase before the upgrade. But again it's really just a nice-to-have, none of this is essential.