Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert downgrading of log error->warn->error #4511

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Revert downgrading of log error->warn->error #4511

merged 1 commit into from
Oct 23, 2024
+12 −4

Conversation

ThomasBrady
Copy link
Contributor

Description

Reverts downgrading of error to warning in CheckSingleLedgerHeaderWork

#4508 (comment)

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@ThomasBrady ThomasBrady mentioned this pull request Oct 21, 2024
Merged
@ThomasBrady ThomasBrady force-pushed the improve-history-download-logs-and-docs branch 3 times, most recently from 8818b88 to 07d1284 Compare October 22, 2024 23:11
@ThomasBrady ThomasBrady force-pushed the improve-history-download-logs-and-docs branch from 9c30d74 to 7bc6ea5 Compare October 23, 2024 22:04
@ThomasBrady ThomasBrady force-pushed the improve-history-download-logs-and-docs branch 2 times, most recently from f57a679 to 17d4193 Compare October 23, 2024 22:40
@ThomasBrady @marta-lokhova
Revert downgrading of log error->warn->error
8cdda2e 
use const error message POSSIBLY_CORRUPTED_HISTORY, add more guidance
@marta-lokhova marta-lokhova force-pushed the improve-history-download-logs-and-docs branch from 17d4193 to 8cdda2e Compare October 23, 2024 22:45
@marta-lokhova marta-lokhova added this pull request to the merge queue Oct 23, 2024
Merged via the queue into stellar:master with commit 0d1f034 Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-lokhova marta-lokhova marta-lokhova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasBrady @marta-lokhova