Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change returns tracy to kinda-working on soroban. It does not work on soroban v21 (you still just get an opaque span for such InvokeHostFunction calls) but does:
CXX=clang++-12 CXXFLAGS=-stdlib=libc++
as in CIThere were three major issues to deal with:
manual-lifetime
mode because older versions of the rusttracy-client
crate required it, and this just can't really work when there are multiple copies oftracy-client
linked into the final executable, they fight over who gets to initialize tracy.By abandoning those old versions of
tracy-client
and only enabling new ones that allow turning offmanual-lifetime
, we're in a much better state. The multiple copies oftracy-client
all expect tracy to initialize itself, and it does so, and everything's fine.I did not yet conditionalize-out the memory-tracking code. I might push a further commit here to do so. It seems like it's fairly expensive to have on by default when using tracy, and I'm not sure anyone benefits from it most of the time.