Add support for Soroban constructors (CAP-58) #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
force-pushed
the
soroban_constructor
branch
2 times, most recently
from
d4766d4
to
5d477d1
Compare
dmkozh
changed the title
sisuresh
reviewed
Aug 29, 2024
sisuresh
reviewed
Aug 29, 2024
sisuresh
approved these changes
Aug 30, 2024
dmkozh
force-pushed
the
soroban_constructor
branch
from
cf093d7
to
81c0c9e
Compare
This doesn't have much logic beyond env/XDR bumps and basic test coverage. However, the check for not supporting the new XDR in the old protocol is done in generic fashion via Soroban env XDR roundtrip.
dmkozh
force-pushed
the
soroban_constructor
branch
from
81c0c9e
to
d1e448c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4437, stellar/rs-soroban-env#1438
This doesn't have much logic beyond env/XDR bumps and basic test coverage. However, the check for not supporting the new XDR in the old protocol is done in generic fashion via Soroban env XDR roundtrip.
This also includes a few test fixes to unblock CI.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)