Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of reduce in maxReadQuotaForKey, simplify accounting data structure #4419

Merged

Conversation

ThomasBrady
Copy link
Contributor

Description

Remove usage of std::reduce from LedgerKeyMeter::maxReadQuotaForKey

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

SirTyson
SirTyson previously approved these changes Aug 6, 2024
Copy link
Contributor

@SirTyson SirTyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasBrady ThomasBrady changed the title Remove usage of reduce in maxReadQuotaForKey Remove usage of reduce in maxReadQuotaForKey, simplify accounting data structure Aug 6, 2024
…d mLedgerKeyToTx in LedgerKeyMeter with shared pointers in mLedgerKeyToTxReadBytes
@ThomasBrady ThomasBrady force-pushed the simplify-max-read-quota-for-key branch from 5038098 to a8869a9 Compare August 6, 2024 20:27
@ThomasBrady ThomasBrady self-assigned this Aug 6, 2024
@marta-lokhova marta-lokhova added this pull request to the merge queue Aug 7, 2024
Merged via the queue into stellar:master with commit 3089d1c Aug 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants