Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assert failure when Soroban tx was sumbitted pre p20 #4414

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Aug 5, 2024

Description

Following the TX frame refactor, there is an assertion failure when submitting Soroban TXs pre protocol 20. This was actually a bug before the refactor, where a Soroban TX would fail to get added to the queue with ADD_STATUS_ERROR, but the diagnostics would report txSUCCESS. The assert is correct, but the queue now rejects the transaction and sets txNOT_SUPPORTED. This is TX queue behavior so this won't effect TX replay.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@marta-lokhova marta-lokhova added this pull request to the merge queue Aug 5, 2024
Merged via the queue into stellar:master with commit e7e7678 Aug 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants