Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis-tools as a test-only docker dependency #4390

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented Jul 18, 2024

Description

redis-cli is needed for the container to communicate to the Redis host.
The new parallel catchup mission stellar/supercluster#178 requires access to Redis task queue.
This is only added as a test dependency i.e. package version with *~buildtests, and does not affect production stellar-core packages.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@jayz22 jayz22 marked this pull request as ready for review July 26, 2024 15:59
@jayz22 jayz22 requested a review from graydon July 26, 2024 15:59
@graydon graydon enabled auto-merge July 26, 2024 16:06
@graydon graydon added this pull request to the merge queue Jul 26, 2024
Merged via the queue into stellar:master with commit f949c77 Jul 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants