Fail loadgen when pending accounts are found in available accounts list #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although `mAccountsAvailable` shouldn't contain pending accounts, it is possible when the network is overloaded. Consider the following scenario: 1. A node generates a transaction `t` using account `a` and broadcasts it on. In doing so, loadgen marks `a` as in use, removing it from `mAccountsAvailable. 2. For whatever reason, `t` never makes it out of the queue and the node bans it. 3. After some period of time, the node unbans `t` because bans only last for so many ledgers. 4. Loadgen marks `a` available, moving it back into `mAccountsAvailable`. 5. The node hears about `t` again on the network and (as it is no longer banned) adds it back to the queue 6. getNextAvailableAccount draws `a` from `mAccountsAvailable`. However, `a` is no longer available as `t` is in the transaction queue! In this scenario, returning `a` results in an assertion failure later. This change instead detects this and marks the loadgen run as failed.
marta-lokhova
requested changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although
mAccountsAvailableshouldn't contain pending accounts, it is possible when the network is overloaded. Consider the following scenario:tusing accountaand broadcasts it on. In doing so, loadgen marksaas in use, removing it from `mAccountsAvailable.tnever makes it out of the queue and the node bans it.tbecause bans only last for so many ledgers.aavailable, moving it back intomAccountsAvailable.tagain on the network and (as it is no longer banned) adds it back to the queueafrommAccountsAvailable. However,ais no longer available astis in the transaction queue!In this scenario, returning
aresults in an assertion failure later. This change instead detects this and marks the loadgen run as failed.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)