Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings upgrades for increasing the maximum Soroban key size to 250 bytes #4371

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jun 28, 2024

Description

Settings upgrades for increasing the maximum Soroban key size to 250 bytes.

200 bytes ended up being too conservative and it's not sufficient to support the built-in Stellar Asset contract allowance (that might need up to 204 bytes/key).

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

…bytes.

200 bytes ended up being too conservative and it's not sufficient to support the built-in Stellar Asset contract allowance (that might need up to 204 bytes/key).
@sisuresh sisuresh enabled auto-merge June 28, 2024 16:29
@sisuresh sisuresh added this pull request to the merge queue Jun 28, 2024
Merged via the queue into stellar:master with commit 68f43a5 Jun 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants