Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucketlist db invariant #4369

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Bucketlist db invariant #4369

merged 1 commit into from
Jul 1, 2024

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Jun 27, 2024 •
edited
Loading

Description

Resolves #4368

Fixes BucketListIsConsistentWithDatabase when BucketListDB is enabled.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@dmkozh dmkozh added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@sisuresh sisuresh added this pull request to the merge queue Jul 1, 2024
Merged via the queue into stellar:master with commit 9cacf71 Jul 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@sisuresh sisuresh Awaiting requested review from sisuresh

@ThomasBrady ThomasBrady Awaiting requested review from ThomasBrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BucketListIsConsistentWithDatabase broken with BucketListDB
3 participants
@SirTyson @dmkozh @sisuresh