Improve performance of dump-ledger #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for the optimization. In order to get past the cargo-deny check you just need to change deny.toml like here: dmkozh@aa935a9#diff-1040309c64844eb1b6b63d8fd67938adbf9461f1b3c61f12cf738f064a02d3de |
As per standard, std::optional copies/moves the underlying object but asio::io_context cannot be moved/copied.
MonsieurNicolas
force-pushed
the
dumpLedgerPerfFix
branch
from
85f113b
to
864d46a
Compare
dmkozh
approved these changes
Jun 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how dump-ledger operate as to use a lot less memory:
previously running a command such as
stellar-core dump-ledger --output-file out.json --group-by "data.type" --agg "count()"against pubnet would crash nodes by using up all memory (16GB).This version uses much less memory (peaks at 4GB) by not storing the current bucket in memory and not storing all seen keys from the bucket list in RAM.
This PR also includes a couple compile/link fixes for Windows.