Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test target size logic in upgrade test #4111

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Test target size logic in upgrade test #4111

merged 4 commits into from
Jan 2, 2024

Conversation

sisuresh
Copy link
Contributor

Description

  1. Hit target size in upgrade test.
  2. Add safety check in utils.
  3. Increase fees to handle hitting target size.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from dmkozh December 22, 2023 23:06
dmkozh
dmkozh reviewed Dec 22, 2023
View reviewed changes
src/main/SettingsUpgradeUtils.cpp

return {txEnv, contractSourceRefLedgerKey, contractID};
}

void
validateConfigUpgradeSet(ConfigUpgradeSet const& upgradeSet)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we quickly cover this check triggering in some test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dmkozh
Copy link
Contributor

dmkozh commented Dec 23, 2023

r+ 6cdf449

@dmkozh
Copy link
Contributor

dmkozh commented Jan 2, 2024

r+ 249e42f

@latobarita latobarita merged commit f3ff78d into stellar:master Jan 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisuresh @dmkozh @latobarita