Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Soroban test framework. #4089

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Dec 12, 2023

Description

Refactor Soroban test framework.

  • Allow deploying an arbitrary number of different contracts within a test
  • Provide a wrapper for the contracts and invocations to allow building/invoking transactions with less code
  • Provide a wrapper for the Soroban resources and fees for easier and more readable resource/fee overrides
  • Move the invocation/results to return values for more precise REQUIRE locations
  • Update InvokeHostFunctionTests to use the updated utils and re-organize/rename a few tests
  • Remove functions that re-implement the fee computation logic (these simply didn't cover anything and are no longer useful for iteration given that protocol is finalized)

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

- Allow deploying an arbitrary number of different contracts within a test
- Provide a wrapper for the contracts and invocations to allow building/invoking transactions with less code
- Provide a wrapper for the Soroban resources and fees for easier and more readable resource/fee overrides
- Update InvokeHostFunctionTests to use the updated utils
- Remove functions that re-implement the fee computation logic (these simply didn't cover anything and are no longer useful for iteration given that protocol is finalized)
@sisuresh
Copy link
Contributor

r+ 8e3af21

@latobarita latobarita merged commit 6f5df54 into stellar:master Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants