Overlay: Do not initiate connections that will be immediately dropped #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Dec 5, 2023
marta-lokhova
approved these changes
Dec 7, 2023
This change ensures that the overlay does not initiate outbound connections when it is shutting down (and therefore `OverlayManagerImpl::addOutboundConnection` will immediately drop the connection). This change also adds a line to the logs indicating how to increase the number of outbound pending slots when `OverlayManagerImpl::connectToImpl` fails due to insufficient slots.
bboston7
force-pushed
the
outbound-connection-drop
branch
from
c39ffe4
to
2c55512
Compare
|
r+ 2c55512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that the overlay does not initiate outbound connections when it is shutting down (and therefore
OverlayManagerImpl::addOutboundConnectionwill immediately drop the connection).This change also adds a line to the logs indicating how to increase the number of outbound pending slots when
OverlayManagerImpl::connectToImplfails due to insufficient slots.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)