Added BucketListSizeSnapshots upgrade test #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Oct 27, 2023
src/herder/test/UpgradesTests.cpp
Outdated
| } | ||
|
|
||
| // Verify average has been properly updated as well | ||
| REQUIRE(cfg.getAverageBucketListSize() == (sum / 40)); |
There was a problem hiding this comment.
is there value in testing upgrades to 0 (should throw instead of UB), and to the same size as before (should no-op)?
SirTyson
force-pushed
the
size-snapshot-upgrade
branch
from
c10e69f
to
6a5ed0d
Compare
marta-lokhova
requested changes
Oct 30, 2023
|
r+ 6a5ed0d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3798
Adds upgrade tests for
BucketListSizeSnapshotsupgrades.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)