-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soroban Meta Tests #3984
Soroban Meta Tests #3984
Conversation
0ea8cca
to
c95503d
Compare
4a0c09d
to
94573dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. I'm not an expert on invoke host function, so I only did a cursory check there. Could you rebase on top of master please? We'll prioritize merging this change then, to avoid more merge conflicts.
src/test/TxTests.h
Outdated
@@ -138,6 +138,10 @@ TransactionFramePtr transactionFromOperations(Application& app, | |||
SequenceNumber seq, | |||
std::vector<Operation> const& ops, | |||
uint32_t fee = 0); | |||
TransactionFramePtr sorobanTransactionFromOperations( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this separate function given that we have sorobanTransactionFrameFromOps
already? you could update the existing function to generate desired signatures (also, if you don't need to override signatures too often, you could add the override logic directly into the test that needs it, like we do in other tests):
stellar-core/src/herder/test/HerderTests.cpp
Line 272 in af8b65a
getSignatures(tx).clear(); |
src/test/TestAccount.cpp
Outdated
SorobanResources const& resources, uint32_t inclusionFee, | ||
uint32_t resourceFee, std::optional<std::string> memo) | ||
{ | ||
loadSequenceNumber(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe with the latest changes to sorobanTransactionFrameFromOps
, we don't need to do this anymore, since you can now pass expected seqnum directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(though you'd need to rebase/resolve merge conflicts)
94573dd
to
59c721d
Compare
e9655cc
to
401383f
Compare
r+ 401383fc4d663be90fc8f21964c54072c2001c3f |
401383f
to
b1040ac
Compare
r+ b1040ac |
Description
Resolves #3878 and #3859
Overhauls
InvokeHostFunctionTests
, providing better coverage and more readability. Also adds a test for recording Soroban TX meta. Currently, we test the meta for contract storage, TTL extension, restoration, contract deployment, and failed invocations.Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)