Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build #3956

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix Windows build #3956

merged 1 commit into from
Sep 29, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Sep 29, 2023

Description

Fix Windows build of Core:

  • Added missing files to project
  • Use more cross-platform friendly filesystem methods

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@MonsieurNicolas
Copy link
Contributor

r+ eee8c85

@latobarita latobarita merged commit f88cf99 into stellar:master Sep 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmkozh @MonsieurNicolas @latobarita