Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban ENABLE_SOROBAN_DIAGNOSTIC_EVENTS when isNetworkedValidator #3934

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/ApplicationImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,13 @@ ApplicationImpl::validateAndLogConfig()
auto const isNetworkedValidator =
mConfig.NODE_IS_VALIDATOR && !mConfig.RUN_STANDALONE;

if (mConfig.ENABLE_SOROBAN_DIAGNOSTIC_EVENTS && isNetworkedValidator)
{
throw std::invalid_argument("ENABLE_SOROBAN_DIAGNOSTIC_EVENTS is set, "
"NODE_IS_VALIDATOR is set, and "
"RUN_STANDALONE is not set");
}

if (mConfig.METADATA_OUTPUT_STREAM != "" && isNetworkedValidator)
{
throw std::invalid_argument(
Expand Down