Fee bug #3912
Merged
Fee bug #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
fee-bug
branch
2 times, most recently
from
18acd08
to
577d587
Compare
marta-lokhova
approved these changes
Sep 8, 2023
|
Not critical, but if you have a chance, please squash the commits. Either way, LGTM. |
|
r+ c14f5cc |
2opremio
added a commit
to 2opremio/soroban-cli
that referenced
this pull request
Sep 13, 2023
2opremio
added a commit
to stellar/stellar-cli
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Double counting readWrite.size when computing Soroban resource fees.
This PR fixes an error and fee accounting where entries in the readWrite set of the footprint were charged double readEntry fees. This also includes a testing overhaul where most fee literals are replaced in
InvokeHostFunctionTests.cppChecklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)