Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Double counting readWrite.size when computing Soroban resource fees.
This PR fixes an error and fee accounting where entries in the readWrite set of the footprint were charged double readEntry fees. This also includes a testing overhaul where most fee literals are replaced in
InvokeHostFunctionTests.cpp
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)