Expiration Entry updates and return core-generated DiagnosticEvents on the tx submission endpoint #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
reviewed
Aug 29, 2023
graydon
force-pushed
the
tx-submit-diagnostics
branch
3 times, most recently
from
f25895d
to
890394b
Compare
|
Updated to be in line behind #3899 -- I'll review that tomorrow, it's a little larger than I've got time for tonight. |
graydon
force-pushed
the
tx-submit-diagnostics
branch
from
bc57933
to
1464cec
Compare
|
r+ 1464cec |
MonsieurNicolas
changed the title
|
updated the title as to reflect the actual scope of the PR |
|
r+ 937e092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of this plan. Needs to not land until the corresponding XDR lands, and then env is updated, and then core is updated with XDR and env.