-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump soroban-env-host versions #3890
Conversation
@graydon looks like there's a conflict to fix. |
I've fixed the conflict but there were changes required in the refundable fee tests that I've tried all evening to fix and I simply can't understand; I'm at the point of just randomly changing numbers up and down to make them work and I can't even get that working -- changing one will cause two to move in opposite directions in a way I can't comprehend. @dmkozh could you please pick this up and complete it? I isolated the fee-related changes to the second commit here if you want to just revert it and try again, I won't mind. Whatever you can get to work. |
r+ 0cb9a31 |
@@ -52,11 +52,11 @@ optional = true | |||
version = "0.0.17" | |||
git = "https://github.com/stellar/rs-soroban-env" | |||
package = "soroban-env-host" | |||
rev = "c2e1c21cf8d44db23a159090e3cbaab741860295" | |||
rev = "f5c6c0f42b4094481b7f32ecac825ce27c7114e0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 5dc7547a4b15028787d57a849a7684802d899fc7
like the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to point to the "previous" host version (the comment has an explanation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry
This just picks up recent changes in the soroban env (specifically the newest XDR as of today, including removal of ScSpecTypeSet)