-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump env version, update cost parameters #3876
Conversation
bumpWithFootprint("key", UINT32_MAX, contractKeys, | ||
{contractDataKey(contractID, makeSymbolSCVal("key"), | ||
ContractDataDurability::PERSISTENT, DATA_ENTRY)}, | ||
false, ContractDataDurability::PERSISTENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the right update to this test @sisuresh since the bump past max ledger is no longer allowed by the env?
|
||
auto maxExpiration = | ||
ledgerSeq + stateExpirationSettings.maxEntryExpiration - 1; | ||
checkContractDataExpirationLedger( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing this, I would do a bump to the max and check that it worked.
r+ 2a5c1da |
r+ 652cac1 |
Description
Bump env version to pick up the changes.
Update cost parameters.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)