Bump env version, update cost parameters #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
commented
Aug 10, 2023
| bumpWithFootprint("key", UINT32_MAX, contractKeys, | ||
| {contractDataKey(contractID, makeSymbolSCVal("key"), | ||
| ContractDataDurability::PERSISTENT, DATA_ENTRY)}, | ||
| false, ContractDataDurability::PERSISTENT); |
There was a problem hiding this comment.
I think this is the right update to this test @sisuresh since the bump past max ledger is no longer allowed by the env?
sisuresh
reviewed
Aug 10, 2023
|
|
||
| auto maxExpiration = | ||
| ledgerSeq + stateExpirationSettings.maxEntryExpiration - 1; | ||
| checkContractDataExpirationLedger( |
There was a problem hiding this comment.
Instead of removing this, I would do a bump to the max and check that it worked.
|
r+ 2a5c1da |
|
r+ 652cac1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump env version to pick up the changes.
Update cost parameters.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)