Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for soroban config setting upgrade with minimum settings #3871

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Add test case for soroban config setting upgrade with minimum settings #3871

merged 3 commits into from
Aug 8, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Aug 3, 2023

Description

Related to #3820 (comment).

Depends on stellar/rs-soroban-env#983.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh mentioned this pull request Aug 3, 2023
Merged
@sisuresh sisuresh marked this pull request as ready for review August 8, 2023 19:46
@sisuresh sisuresh requested a review from dmkozh August 8, 2023 19:49
@dmkozh
Copy link
Contributor

dmkozh commented Aug 8, 2023

r+ d4ad454

@latobarita latobarita merged commit 1a29f89 into stellar:master Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh Awaiting requested review from dmkozh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisuresh @dmkozh @latobarita