-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meta #3844
Fix meta #3844
Conversation
virtual void erase(InternalLedgerKey const& key) = 0; | ||
virtual LedgerTxnEntry load(InternalLedgerKey const& key) = 0; | ||
virtual LedgerTxnEntry load(InternalLedgerKey const& key, | ||
bool loadExpiredEntry = false) = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this an optional parameter in the interest of time. We're going to remove this anyways so it should be fine.
Marked as draft so we don't merge this in prior to when the 19.13.0 release is cut. |
@@ -1526,15 +1461,17 @@ LedgerTxn::Impl::getNewestVersion(InternalLedgerKey const& key, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add an expiration check above in LedgerTxn::Impl::getNewestVersion
now that mEntry
may contain expired entries since load
may make an expired entry active. This also applies in getNewestVersionEntryMap
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the src/transactions/RestoreFootprintOpFrame.cpp
issue with last modified ledgerSeq is fixed. We're not gonna keep this so you can just loadWithoutRecord
, then if you actually update something just load
another copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved by #3857 |
Description
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)