Fix meta #3844
Closed
Fix meta #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
commented
Jul 20, 2023
| virtual void erase(InternalLedgerKey const& key) = 0; | ||
| virtual LedgerTxnEntry load(InternalLedgerKey const& key) = 0; | ||
| virtual LedgerTxnEntry load(InternalLedgerKey const& key, | ||
| bool loadExpiredEntry = false) = 0; |
There was a problem hiding this comment.
I made this an optional parameter in the interest of time. We're going to remove this anyways so it should be fine.
|
Marked as draft so we don't merge this in prior to when the 19.13.0 release is cut. |
SirTyson
reviewed
Jul 20, 2023
| @@ -1526,15 +1461,17 @@ LedgerTxn::Impl::getNewestVersion(InternalLedgerKey const& key, | |||
|
|
|||
There was a problem hiding this comment.
Need to add an expiration check above in LedgerTxn::Impl::getNewestVersion now that mEntry may contain expired entries since load may make an expired entry active. This also applies in getNewestVersionEntryMap.
SirTyson
approved these changes
Jul 21, 2023
|
Resolved by #3857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)