temp entry invariant fix #3831
Merged
temp entry invariant fix #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
temp-fix
branch
2 times, most recently
from
66c9e91
to
c3b133a
Compare
SirTyson
commented
Jul 16, 2023
| @@ -961,11 +975,6 @@ mergeCasesWithEqualKeys(MergeCounters& mc, BucketInputIterator& oi, | |||
| else | |||
| { | |||
| // Merge a create+delete to nothingness. | |||
| if (newEntry.type() != DEADENTRY) | |||
There was a problem hiding this comment.
Just to sanity check, this code in inaccessible, right? I'm deleting it because I was thinking about if a valid TEMPORARY entry could somehow cause this to throw when I realized this branch is not possible.
|
r+ f5ba8a55e68188deea2a67a87e3ec52ff95852ce |
|
r+ cbcfd20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
TEMPORARYentry invariant bug that killed preview 10 future net.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)