Bump expiration op #3775
Bump expiration op #3775
Conversation
There was a problem hiding this comment.
We should probably strictly enforce MAX_ENTRY_LIFETIME for manual bumps. For autobumps and contract defined bumps, if the requested lifetime extension goes beyond the maximum, we don't fail, but just bump up to the maximum. Here it might make more sense to actually fail, since the user is manually specifying the bump amount. If a user specifies 10 years of rent in the manual bump op, it's probably best to fail instead of bumping the entry by only a year and silently ignore the 9 years of additional rent.
| return false; | ||
| } | ||
| } | ||
| return true; |
There was a problem hiding this comment.
We should set the code to BUMP_EXPIRATION_MALFORMED and fail here if op.ledgersToExpire > networkConfig.maxEntryExpiration to more strictly enforce the max.
| // Multiply by 2 for the metadata check since the previous state is | ||
| // also included in the meta. | ||
| if (resources.extendedMetaDataSizeBytes < | ||
| metrics.mLedgerWriteByte * 2 || |
There was a problem hiding this comment.
To avoid integer overflow with multiplication of 2, should we use division instead?
There was a problem hiding this comment.
Done. This should be changing anyways when we start using EXPIRATION_EXTENSIONS.
| if (UINT32_MAX - ledgerSeq > mBumpExpirationOp.ledgersToExpire()) | ||
| { | ||
| bumpTo = ledgerSeq + mBumpExpirationOp.ledgersToExpire(); | ||
| } |
There was a problem hiding this comment.
Should we cover the else condition as well? Assuming UINT32_MAX is the max Ledger sequence,
bumpTo = Math.min(ledgerSeq + mBumpExpirationOp.ledgersToExpire(), UINT32_MAX)
There was a problem hiding this comment.
The initial value of bumpTo is UINT32_MAX, so that else case is already handled.
sisuresh
force-pushed
the
bump-op
branch
2 times, most recently
from
a3314d8 to
8a2bc55
Compare
|
r+ b5386da |
Bump expiration op Reviewed-by: dmkozh
Description
Resolves stellar/rs-soroban-env#759.
Uses xdr from stellar/stellar-xdr#106.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)