Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of base XDR git version (was reporting "next") #3684

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Mar 23, 2023

In this change @leighmcculloch changed the meaning of one of the version fields from rs-stellar-xdr. As a result, lately we've just been reporting the string "next" for the base XDR git version, rather than a proper hash.

This PR adapts to the change and thus fixes the externally observable behaviour back to what it was before.

Before this change:

$ ./src/stellar-core version
v19.8.0-33-g53ea43ace
rust version: rustc 1.68.0 (2c8cc3432 2023-03-06)
soroban-env-host: 
    package version: 0.0.14
    git version: 7dde7cb0b35957856a1e0c11432e00532ae20cf8
    interface version: 32
    rs-stellar-xdr:
        package version: 0.0.14
        git version: 07aff1190dc3f97b889d31b2bfb77098e7db55ce
        base XDR git version: next

With this change:

$ ./src/stellar-core version
v19.8.0-33-g53ea43ace-dirty
rust version: rustc 1.68.0 (2c8cc3432 2023-03-06)
soroban-env-host: 
    package version: 0.0.14
    git version: 7dde7cb0b35957856a1e0c11432e00532ae20cf8
    interface version: 32
    rs-stellar-xdr:
        package version: 0.0.14
        git version: 07aff1190dc3f97b889d31b2bfb77098e7db55ce
        base XDR git version: 7356dc237ee0db5626561c129fb3fa4beaabbac6

@graydon graydon requested a review from sisuresh March 23, 2023 20:43
@sisuresh
Copy link
Contributor

r+ f404b16

@latobarita latobarita merged commit 86e33f3 into stellar:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants