Added BucketListDB init tests and invariant checks #3626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3623.
This PR adds several captive-core and BucketListDB related unit tests. In particular, it tests the BucketListDB startup path and several edge cases for in-memory mode in captive-core. There are also several bug fixes, including fixing BucketList related invariants that were broken when BucketListDB was enabled and some captive-core performance bugs introduced by BucketListDB.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)