-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on pull mode by default #3575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. we also need to make sure that minimum overlay version is up-to-date
note: we should merge this change last, before closing the tree, so we can do perf run before/after with all the other changes already in |
src/main/Config.cpp
Outdated
@@ -127,7 +127,7 @@ Config::Config() : NODE_SEED(SecretKey::random()) | |||
|
|||
MAXIMUM_LEDGER_CLOSETIME_DRIFT = 50; | |||
|
|||
OVERLAY_PROTOCOL_MIN_VERSION = 21; | |||
OVERLAY_PROTOCOL_MIN_VERSION = 22; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can actually bump to 23 that corresponds to 19.3.0 released in July (this is in line with our release policy of 90 days)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
0b196f4
to
4a69978
Compare
4a69978
to
83da984
Compare
r+ 83da984 |
Description
Resolves #3572
This turns on pull mode by default. Note that node operators can still turn it off through the config file. Furthermore, this bumps the overlay protocol version.
Checklist
clang-format
v8.0.0 (viamake format
or the Visual Studio extension)