Turn on pull mode by default #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
requested changes
Oct 7, 2022
|
note: we should merge this change last, before closing the tree, so we can do perf run before/after with all the other changes already in |
MonsieurNicolas
requested changes
Oct 8, 2022
src/main/Config.cpp
Outdated
| @@ -127,7 +127,7 @@ Config::Config() : NODE_SEED(SecretKey::random()) | |||
|
|
|||
| MAXIMUM_LEDGER_CLOSETIME_DRIFT = 50; | |||
|
|
|||
| OVERLAY_PROTOCOL_MIN_VERSION = 21; | |||
| OVERLAY_PROTOCOL_MIN_VERSION = 22; | |||
There was a problem hiding this comment.
we can actually bump to 23 that corresponds to 19.3.0 released in July (this is in line with our release policy of 90 days)
There was a problem hiding this comment.
Updated!
hidenori-shinohara
force-pushed
the
pull-mode-on
branch
from
0b196f4
to
4a69978
Compare
hidenori-shinohara
force-pushed
the
pull-mode-on
branch
from
4a69978
to
83da984
Compare
|
r+ 83da984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3572
This turns on pull mode by default. Note that node operators can still turn it off through the config file. Furthermore, this bumps the overlay protocol version.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)